Re: [PATCH v2] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Erik Faye-Lund <kusmabite@xxxxxxxxx> writes:

> On Wed, Apr 30, 2014 at 5:13 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> I think something along the lines of
>>
>>         ifdef CURLDIR
>>                 CURL_LIBCURL =
>>         else
>>                 CURL_CONFIG = curl-config
>>                 CURL_LIBCURL := $(shell sh -c '$(CURL_CONFIG) --libs' 2>/dev/null)
>>         fi
>>
>> may be the right way to write this?
>>
>> Note that $(shell $(CURL_CONFIG) --libs) when CURL_CONFIG is empty
>> would barf when $(CURL_CONFIG) expands to an empty string.
>
> There's still the fact that msysGit does *not* need CURLDIR, but
> doesn't have curl-config either. So I think this one will also
> complain for us.

Even with 2>/dev/null?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]