On Wed, Apr 30, 2014 at 05:58:06PM +0900, Brian Gesiak wrote: > strbuf_trim strips whitespace from the end, then the beginning of a > strbuf. Those operations are duplicated in strbuf_rtrim and > strbuf_ltrim. > > Replace strbuf_trim implementation with calls to strbuf_rtrim, > then strbuf_ltrim. Thanks, this looks good. I wondered if perhaps doing them together inline might have been more efficient, but there really is no overlap in what they compute. The documentation patch looks good to me, too. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html