Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: >> >>>> CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \ >>>> -e 's/^Signed-off-by: \(.*\)/\1,/gp'` >>> >>> It looks like you may have missed a usage here due to the line break. >> >> Good eyes ;-) >> >> The following may be an obvious replacement patch, but alternatively >> we could just drop the whole thing (contrib/ material is not >> something we would need to police strictly for the style---nobody >> should be mimicking their styles as they are not part of _our_ >> codebase in the first place). > > My vote goes for keeping the patch as it is, so that future people > grepping for `...` construct do not find any after the series is > finished. > > (and because it's simple to do) Sure, let's do that. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html