Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 23, 2014 at 06:43:56AM -0700, Elia Pinto wrote:
> @@ -25,11 +25,11 @@ fi
>  
>  cd - > /dev/null
>  
> -SUBJECT=`sed -n -e '/^Subject: /p' "${PATCH}"`
> -HEADERS=`sed -e '/^'"${SEP}"'$/,$d' $1`
> -BODY=`sed -e "1,/${SEP}/d" $1`
> -CMT_MSG=`sed -e '1,/^$/d' -e '/^---$/,$d' "${PATCH}"`
> -DIFF=`sed -e '1,/^---$/d' "${PATCH}"`
> +SUBJECT=$(sed -n -e '/^Subject: /p' "${PATCH}")
> +HEADERS=$(sed -e '/^'"${SEP}"'$/,$d' $1)
> +BODY=$(sed -e "1,/${SEP}/d" $1)
> +CMT_MSG=$(sed -e '1,/^$/d' -e '/^---$/,$d' "${PATCH}")
> +DIFF=$(sed -e '1,/^---$/d' "${PATCH}")
>  
>  CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
>  	-e 's/^Signed-off-by: \(.*\)/\1,/gp'`

It looks like you may have missed a usage here due to the line break.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]