On Fri, Mar 21, 2014 at 10:07:15PM +0100, Johannes Sixt wrote: > Add an infrastructure that simplifies adding new tests of the hunk > header regular expressions. > > To add new tests, a file with the syntax to test can be dropped in the > directory t4018. The README file explains how a test file must contain; > the README itself tests the default behavior. I really like the cleanups you've done in t4018. I noticed how messy it was when I modified it recently, but I didn't take the time to clean it. > diff --git a/t/t4018/README b/t/t4018/README > new file mode 100644 > index 0000000..283e01cc > --- /dev/null > +++ b/t/t4018/README > @@ -0,0 +1,18 @@ > +How to write RIGHT test cases > +============================= > + > +Insert the word "ChangeMe" (exactly this form) at a distance of > +at least two lines from the line that must appear in the hunk header. The existing tests use -U1 to make writing cases simpler. Is there a reason not to continue that (or if you found that porting the existing cases was not a chore with -U3, I can buy that argument, too)? > +The text that must appear in the hunk header must contain the word > +"right", but in all upper-case, like in the title above. > + > +To mark a test case that highlights a malfunction, insert the word > +BROKEN in all lower-case somewhere in the file. I wondered why you wouldn't write them in the case you are indicating, when... > +This text is a bit twisted and out of order, but it is itself a > +test case for the default hunk header pattern. Know what you are doing > +if you change it. Ah. Clever. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html