On Mon, Mar 17, 2014 at 3:23 AM, Matthieu Moy
<Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
> Dragos Foianu <dragos.foianu@xxxxxxxxx> writes:
>
>> + const char *verbose_prints[4] = {
>> + "Branch %s set up to track remote branch %s from %s%s",
>> + "Branch %s set up to track local branch %s%s",
>> + "Branch %s set up to track remote ref %s%s",
>> + "Branch %s set up to track local ref %s%s"
>> + };
>> + char *verbose_rebasing = rebasing ? " by rebasing." : ".";
>> +
>
> This seems to be a "lego construct" that makes translation harder: are
> you sure that the "by rebasing" will be at the end of the sentence in
> any languages?
Read this thread [1] for more details about why this approach is problematic.
[1]: http://thread.gmane.org/gmane.comp.version-control.git/243793/focus=243824
> Also, this lacks the _() on verbose_rebasing, which isn't translatable
> anymore after your patch.
>
> I personnally think that the table-driven approach is wrong here, it
> makes the code shorter but much harder to read.
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html