On 03/10/2014 01:08 PM, Brad King wrote: >> - die("update %s missing [<oldvalue>] NUL", update->ref_name); >> + die("update %s missing <oldvalue>", update->ref_name); > > The reason for the original wording is that the <oldvalue> is indeed > optional. This can only occur at end-of-input, and it is actually the > *NUL* that is missing because an empty old value can be specified to > mean that it it intentionally missing. I see a following patch makes the wording even clearer about unexpected end of input, so ignore my previous review. -Brad -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html