On Sat, Mar 1, 2014 at 7:51 AM, He Sun <sunheehnus@xxxxxxxxx> wrote: > 2014-03-01 19:21 GMT+08:00 Faiz Kothari <faiz.off93@xxxxxxxxx>: >> diff --git a/remote-curl.c b/remote-curl.c >> index 10cb011..dee8716 100644 >> --- a/remote-curl.c >> +++ b/remote-curl.c >> @@ -634,7 +634,7 @@ static int rpc_service(struct rpc_state *rpc, struct discovery *heads) >> if (start_command(&client)) >> exit(1); >> if (preamble) >> - write_or_die(client.in, preamble->buf, preamble->len); >> + strbuf_write_or_die(client.in, preamble); >> if (heads) >> write_or_die(client.in, heads->buf, heads->len); > > This should be changed. May be you can use Ctrl-F to search write_or_die(). > Or if you are using vim, use "/ and n" to find all. It's not obvious from the patch fragment, but 'heads' is not a strbuf, so Faiz correctly left this invocation alone. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html