On Sat, Mar 1, 2014 at 9:47 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sat, Mar 1, 2014 at 7:18 PM, Faiz Kothari <faiz.off93@xxxxxxxxx> wrote: >> Implementing this clearly distinguishes between writing a normal buffer >> and writing a strbuf. Also, it provides an interface to write strbuf >> directly without knowing the private members of strbuf, making strbuf >> completely opaque. Also, makes the code more readable. > > These three sentences which justify the change should go above the > "---" line so they are recorded in the project history for future > readers to understand why the change was made. As for their actual > value, the first and third sentences are nebulous; the second sentence > may be suitable (although strbuf's buf and len are actually considered > public, so the justification not be supportable). ...justification *may* not be... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html