On Feb 4, 2007, at 8:30 PM, Junio C Hamano wrote:
In reality, I find highly valuable that our tests find new bugs introduced in unexpected places. I agree that the person who wrote t9200 did not _mean_ to test "git add", but it ended up helping us identify the problematic behaviour between creat() and readdir() on HFS+ affects "git add".
Alright, I understand that. I just meant that since we've identified it, the workaround didn't matter much.
So how about doing this instead? It tests if the filesystem has that particular issue we know "git add" has a problem with, and skips the test in such an environment.
Yes, something like this is fine. The patch looks good, but I couldn't get it to apply and don't have the time to fix it at the moment. If you *need* me to test it, I'll do so tomorrow or Tuesday.
~~ Brian - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html