Re: [PATCH] Use "-f" when adding files with odd names in t9200.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Brian Gernhardt <benji@xxxxxxxxxxxxxxxxxx> writes:

> Without -f, the UTF-8 named files are ignored (supposedly via
> .gitignore) on systems with a different UTF-8 encoding.
> This patch makes the test pass on OS X on HFS+, in particular.
>
> Signed-off-by: Brian Gernhardt <benji@xxxxxxxxxxxxxxxxxx>
> ---
>  
>  I still think that the behavior of git-add here is an error.  The file
>  is NOT in any ignore file and so should not be marked as such.

Can you describe why git-add finds the (presumably mangled by
HFS) path in ".gitignore"?  If we had some default pattern in
info/exclude that is installed in the trash test repository I
would understand that a mangled path could happen to match it,
but I do not think we do not have any exclude pattern by
default.

Unless/until you know why git-add thinks it is ignored,...

>  However,
>  this allows me to finally use "make test && sudo make install".

... I think this change means you are installing something the
existing test knows to be broken, which is not very pretty.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]