On Thu, Dec 05, 2013 at 01:44:12PM -0800, Junio C Hamano wrote: > ;-) Good flow of thought. As to your rev-parse change, I don't > immediately think of a hole/flaw offhand; it looked a good > straight-forward change to me. Here it is with tests and a commit message. While writing the tests, I noticed that also do not handle true ambiguity the same (we prefer revs, rather than complaining). That's fixed in the second commit. [1/2]: rev-parse: correctly diagnose revision errors before "--" [2/2]: rev-parse: diagnose ambiguous revision/filename arguments -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html