Jeff King <peff@xxxxxxxx> writes: > BTW, the raw looping to find "--" made me wonder how we handle: > > git log --grep -- HEAD > > I'd expect it to be equivalent to: > > git log --grep=-- HEAD > > but it's not; we truncate the arguments and complain that --grep is > missing its argument. Which is probably good enough, given that the > alternative is doing a pass that understands all of the options. But it > does mean that the "--long-opt=arg" form is safer than the split form if > you are passing along an arbitrary "arg". ;-) Good flow of thought. As to your rev-parse change, I don't immediately think of a hole/flaw offhand; it looked a good straight-forward change to me. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html