On Sat, Nov 09, 2013 at 10:03:56PM +0100, Thomas Rast wrote: > > Of course. You write little endian and also read back little endian; > > that should work just fine, no? > > > > OTOH, if you write with Intel and read with PPC, then you should observe > > misbehavior with the above patch. > > Maybe you could check in a simple test that the bitmap for a very > predictable pack (e.g. only one commit) has a certain content, by > checking its hash. That would guard against accidental format changes. Another option would be to cross-check reading and writing against JGit, which is valuable for other reasons besides checking endianness. I do not think most people will have JGit installed, but it's better than nothing (and if even one person runs it, we have a chance of finding a bug). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html