Am 09.11.2013 12:35, schrieb Torsten Bögershausen: > On 2013-11-08 23.29, Jeff King wrote: >> On Fri, Nov 08, 2013 at 06:10:30PM +0100, Torsten Bögershausen wrote: >> >>> Side question: >>> Do we have enough test coverage for htonll()/ntohll(), >>> or do we want do the "module test" which I send a couple of days before ? >> >> The series adds tests for building and using the ewah bitmaps, which in >> turn rely on the htonll code. So they are being tested in the existing >> series. >> >> -Peff > You are thinking about t5310-pack-bitmaps.sh ? > If I do like this in compat/bswap.h > > # define ntohll(n) (n) > # define htonll(n) (n) > (on an Intel processor, little endian) > > then t5310 passes, even if the uint64_t words are written > in little endian to disc instead of big endian. Of course. You write little endian and also read back little endian; that should work just fine, no? OTOH, if you write with Intel and read with PPC, then you should observe misbehavior with the above patch. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html