On Sat, Nov 2, 2013 at 9:40 PM, Johannes Sixt <j6t@xxxxxxxx> wrote: >>> In a number of tests, output that was produced by a shell script is >>> compared to expected output using test_cmp. Unfortunately, the MSYS >>> bash-- >>> when invoked via git, such as in hooks--converts LF to CRLF on output >>> (as produced by echo and printf), which leads to many false positives. >> >> As you correctly point out the LF vs. CRLF issues are caused by MSYS >> bash. Then why are the functions called mingw_* instead of msys_*? I'd >> prefer to make very clear that not MinGW but MSYS is the culprit >> concerning the LF vs. CRLF issues (and also the path mangling issues). > > It's a historical accident. We already have the prerequisite MINGW to > work around various annoyances, most of which are caused by MSYS bash. I > didn't want to invent a new prefix. So maybe it's a good point now to also change the MINGW prerequisite name to MSYS as part of your patch, and then name the functions more appropriately? -- Sebastian Schuberth -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html