When git, the executable, invokes a bash script (hooks, scripted git commands, ...), bash writes its output with CRLF. This causes tests to fail because the expected output does not contain CR, only LF. This fixes the tests by replacing test_cmp with a diff computation that disregards the CR. Patch 1 replaces test_cmp with cmp when binary data is compared. Patch 2 is the actual fix. Patch 3 removes some work-arounds that are not necessary anymore. Johannes Sixt (3): t5300-pack-object: do not compare binary data using test_cmp Windows: a test_cmp that is agnostic to random LF <> CRLF conversions tests: undo special treatment of CRLF for Windows t/lib-credential.sh | 4 --- t/t5300-pack-object.sh | 10 +++---- t/t7407-submodule-foreach.sh | 4 --- t/t9001-send-email.sh | 1 - t/test-lib-functions.sh | 66 ++++++++++++++++++++++++++++++++++++++++++++ t/test-lib.sh | 1 + 6 files changed, 72 insertions(+), 14 deletions(-) -- 1.8.4.33.gd68f7e8 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html