Re: [PATCH 07/19] compat: add endianness helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 26, 2013 at 09:55:36AM +0200, Thomas Rast wrote:

> > The POSIX standard doesn't currently define a `nothll`/`htonll`
> 
> typo: ntohll

Thanks.

> > function pair to perform network-to-host and host-to-network
> > swaps of 64-bit data. These 64-bit swaps are necessary for the on-disk
> > storage of EWAH bitmaps if they are not in native byte order.
> [...]
> > +#		include <byteswap.h>
> 
> Do we need a hack on top similar to what ntoh_l and hton_l do, for
> platforms that do not support unaligned access?

Ugh, probably. I didn't even know about those. But we do use them when
reading the ewah bitmaps, which I believe can be at random offsets. We
should be able to use the same ntoh_l solution.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]