Re: [PATCH] Clear fd after closing to avoid double-close error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Duy Nguyen <pclouds@xxxxxxxxx> writes:

> On Tue, Oct 22, 2013 at 7:10 PM, Jens Lindström <jl@xxxxxxxxx> wrote:
> ...
>> +               if (!args->stateless_rpc)
>> +                       /* Closed by pack_objects() via start_command() */
>> +                       fd[1] = -1;
>>         }
> ...
> Life would have been simpler if fd[1] was _always_ closed by
> send_pack(), like in c20181e (start_command(), if .in/.out > 0, closes
> file descriptors, not the callers - 2008-02-21).

Yeah, that was also my first reaction when I saw the above three
lines after reading the discussion that led to the diagnosis.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]