From: Jens Lindstrom <jl@xxxxxxxxx> In send_pack(), clear the fd passed to pack_objects() by setting it to -1, since pack_objects() closes the fd (via a call to run_command()). Not doing so risks having git_transport_push(), caller of send_pack(), closing the fd again, possibly incorrectly closing some other open file. Signed-off-by: Jens Lindström <jl@xxxxxxxxx> --- send-pack.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/send-pack.c b/send-pack.c index 7d172ef..7def2af 100644 --- a/send-pack.c +++ b/send-pack.c @@ -302,6 +302,9 @@ int send_pack(struct send_pack_args *args, finish_async(&demux); return -1; } + if (!args->stateless_rpc) + /* Closed by pack_objects() via start_command() */ + fd[1] = -1; } if (args->stateless_rpc && cmds_sent) packet_flush(out); -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html