On Wed, Aug 28, 2013 at 11:02 PM, Matthijs Kooijman <matthijs@xxxxxxxx> wrote: > This is a testcase that checks for a problem where, during a specific > shallow fetch where the client does not have any commits that are a > successor of the new shallow root (i.e., the fetch creates a new > detached piece of history), the server would simply send over _all_ > objects, instead of taking into account the objects already present in > the client. Thanks. This reminds me I should add a test case in the 4/6 to demonstrate the regression and let it verify again in 6/6 that the temporary regression is gone. Will reroll the series with your patch included. > > The actual problem was fixed by a recent patch series by Nguyễn Thái > Ngọc Duy already. > > Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx> > --- > t/t5500-fetch-pack.sh | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh > index fd2598e..a022d65 100755 > --- a/t/t5500-fetch-pack.sh > +++ b/t/t5500-fetch-pack.sh > @@ -393,6 +393,17 @@ test_expect_success 'fetch in shallow repo unreachable shallow objects' ' > git fsck --no-dangling > ) > ' > +test_expect_success 'fetch creating new shallow root' ' > + ( > + git clone "file://$(pwd)/." shallow10 && > + git commit --allow-empty -m empty && > + cd shallow10 && > + git fetch --depth=1 --progress 2> actual && > + # This should fetch only the empty commit, no tree or > + # blob objects > + grep "remote: Total 1" actual > + ) > +' > > test_expect_success 'setup tests for the --stdin parameter' ' > for head in C D E F > -- > 1.8.4.rc1 > -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html