Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > Junio C Hamano wrote: >> [...] > > The other comments mostly make sense. > >> After reading what the whole function does, I think the purpose of >> this function is to take gc-lock (with optionally force). Perhaps a >> name along the lines of "lock_gc", "gc_lock", "lock_repo_for_gc", >> would be more appropriate. > > The whole point of this exercise is to _not_ lock up the repo during > gc,... I do not think it is a misnomer to call the entity that locks other instances of gc's "a lock on the repository for gc". Nothing in Duy's code suggests any other commands paying attention to this mechanism and stalling, and I think my comments were clear enough that I was not suggesting such a change. So I am not sure what you are complaining. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html