Lukas Fleischer <git@xxxxxxxxxxxxxx> writes:
> `echo -n` is non-portable. The POSIX specification says:
>
> Conforming applications that wish to do prompting without <newline>
> characters or that could possibly be expecting to echo a -n, should
> use the printf utility derived from the Ninth Edition system.
>
> Since all of the affected shell scripts use a POSIX shell shebang,
> replace `echo -n` invocations with printf.
>
> Signed-off-by: Lukas Fleischer <git@xxxxxxxxxxxxxx>
> ...
> diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh
> index c61d535..ae44117 100644
> --- a/t/perf/perf-lib.sh
> +++ b/t/perf/perf-lib.sh
> @@ -161,7 +161,7 @@ test_perf () {
> echo "$test_count" >>"$perf_results_dir"/$base.subtests
> echo "$1" >"$perf_results_dir"/$base.$test_count.descr
> if test -z "$verbose"; then
> - echo -n "perf $test_count - $1:"
> + printf "%s" "perf $test_count - $1:"
> else
> echo "perf $test_count - $1:"
> fi
> @@ -170,7 +170,7 @@ test_perf () {
> if test_run_perf_ "$2"
> then
> if test -z "$verbose"; then
> - echo -n " $i"
> + printf " %d" "$i"
I'd prefer to see '%s' here; it is more faithful transliteration
from "echo -n".
Thanks, will queue with the above tweak.
> else
> echo "* timing run $i/$GIT_PERF_REPEAT_COUNT:"
> fi
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html