Andy Parkins <andyparkins@xxxxxxxxx> writes: > As a further to the above cleanups, I'm also planning to fix all the sha1 > named variables to be "hash" or "object" or something. It strikes me that > this plan is related to this cleanup and might fix some of the issues like: > >> + "git-read-tree (<sha> | " >> + "[[-m [--aggressive] | --reset | --prefix=<prefix>] " >> + "[-u | -i]] [--exclude-per-directory=<gitignore>] " >> + "<sha1> [<sha2> [<sha3>]])"; I've thought about this more than once but I do not think it is worth to rename variable and functions wholesale. When we do fix-ups to a particular function that has "unsigned char sha1[20]" renaming the variable to hash[OBNAME_SIZE] at the same time would be of less impact, although the clean-up may take longer. On the other hand, I think the usage strings are fair game. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html