Stefan Beller <stefanbeller@xxxxxxxxxxxxxx> writes:
> Indeed the patch tests for both bugs unintentionally.
I was puzzled because I do not think that is what is happening with
the posted patch.
If I drop the tip one from jc/mailmap-case-insensitivity and apply
this patch instead, the test passes (which is good).
git checkout 1ab5d42
git am <sb.mbox
make && cd t && sh t4203-mailmap.sh
Of course, if I revert 543f991 (i.e. do not downcase fix), the test
in this patch fails as expected.
git checkout 1ab5d42
git am <sb.mbox
git show 543f991 | git apply -R
make && cd t && sh t4203-mailmap.sh ;# should fail and does
But if I only revert a66e77e (i.e. off-by-one fix) while still
keeping the downcase fix, the test in this patch should fail---but
it doesn't seem to.
git checkout 1ab5d42
git am <sb.mbox
git show a66e77e | git apply -R -3
make && cd t && sh t4203-mailmap.sh ;# should fail but doesn't
The off-by-one fix seems to be correct from code inspection, but the
new test does not seem to demonstrate a case where the code before
the fix misbehaves.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html