Jeff King <peff@xxxxxxxx> writes: > On Tue, Jul 09, 2013 at 10:26:04PM -0700, Junio C Hamano wrote: > >> Jeff King <peff@xxxxxxxx> writes: >> ... >> > I'm torn on this one. It really does provide us with more compile-time >> > safety checks, but it's annoying that "-Wall -Werror" will no longer >> > work out of the box. >> >> Yeah, that is a show-stopper for me X-<. > > You can "fix" it with -Wno-zero-format-length, so the hassle is not > huge. But I am also inclined to just drop this one. We have lived > without the extra safety for a long time, and list review does tend to > catch such problems in practice. I am tempted to actually merge the original one as-is without any of the workaround, and just tell people to use -Wno-format-zero-length. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html