On Wed, Jun 12, 2013 at 4:47 PM, Célestin Matte
<celestin.matte@xxxxxxxxxx> wrote:
> Le 12/06/2013 22:34, Célestin Matte a écrit :
>>> Célestin Matte <celestin.matte@xxxxxxxxxx> writes:
>> Actually, there still is a problem: the "defined(@array)" (introduced
>> with the change in [21/31]) produces a warning.
>> Benoit also seems to have problems with this patch... I'm waiting for
>> his feedback.
>>
> There is indeed a bug. In patch [21/31], at line 163, it should be
> if (!defined $cmd[0]) {
> instead of
> if (!defined @cmd) {
>
> Should I send yet another version of this series of patch?
Assuming you don't discover more problems, for such a small change in
a lengthy patch series, it might make sense to send a simple "fixup!"
[*1*] patch and ask if Junio would be willing to squash it into v5.
[*1*]: see fixup! in git/Documentation/git-rebase.txt
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html