Le 12/06/2013 22:34, Célestin Matte a écrit :
> Le 12/06/2013 22:02, Matthieu Moy a écrit :
>> Célestin Matte <celestin.matte@xxxxxxxxxx> writes:
>>
>>> Not many changes since v3. This version is only for fixing last typos and
>>> applying Junio's recommandations for [21/31], which I forgot in v4.
>>> At this point, the only patch worth reviewing is [21/31].
>>
>> Thanks. I went through the series again and it all looks good.
>>
>
> Actually, there still is a problem: the "defined(@array)" (introduced
> with the change in [21/31]) produces a warning.
> Benoit also seems to have problems with this patch... I'm waiting for
> his feedback.
>
There is indeed a bug. In patch [21/31], at line 163, it should be
if (!defined $cmd[0]) {
instead of
if (!defined @cmd) {
.
Should I send yet another version of this series of patch?
--
Célestin Matte
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html