On Tue, Jun 11, 2013 at 6:18 PM, Célestin Matte <celestin.matte@xxxxxxxxxx> wrote: > Such a file allows to configure perlcritic. > Here, it is used to prevent to remove many unwanted rules and configure one to s/to prevent// > remove unwanted warnings. > > Signed-off-by: Célestin Matte <celestin.matte@xxxxxxxxxx> > Signed-off-by: Matthieu Moy <matthieu.moy@xxxxxxxxxxxxxxx> > --- > contrib/mw-to-git/.perlcriticrc | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 contrib/mw-to-git/.perlcriticrc > > diff --git a/contrib/mw-to-git/.perlcriticrc b/contrib/mw-to-git/.perlcriticrc > new file mode 100644 > index 0000000..a1f8451 > --- /dev/null > +++ b/contrib/mw-to-git/.perlcriticrc > @@ -0,0 +1,28 @@ > +# These 3 rules demand to add the s, m and x flag to *every* regexp. This is > +# overkill and would be harmful for readability. > +[-RegularExpressions::RequireExtendedFormatting] > +[-RegularExpressions::RequireDotMatchAnything] > +[-RegularExpressions::RequireLineBoundaryMatching] > + > +# This rules says that builtin functions should not be called with parenthesis s/rules/rule/ s/parenthesis/parentheses/ > +# e.g.: (taken from CPAN's documentation) > +# open($handle, '>', $filename); #not ok > +# open $handle, '>', $filename; #ok > +# Applying such a rule would mean modifying a huge number of lines for a > +# question of style. > +[-CodeLayout::ProhibitParensWithBuiltins] > + > +# This rule states that each system call should have its return value checked > +# The problem is that it includes the print call. Checking every print call's > +# return value would be harmful to the code readabilty. > +# This configuration keeps all default function but print. > +[InputOutput::RequireCheckedSyscalls] > +functions = open say close > + > +# This rules demands to add a dependancy for the Readonly module. This is not > +# wished. > +[-ValuesAndExpressions::ProhibitConstantPragma] > + > +# This rule is not really useful (rather a question of style) and produces many > +# warnings among the code. > +[-ValuesAndExpressions::ProhibitNoisyQuotes] > -- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html