On Tue, Jun 11, 2013 at 6:18 PM, Célestin Matte
<celestin.matte@xxxxxxxxxx> wrote:
> A "split ' '" is turned into a "split / /", which changes its behaviour: the
> old method matched a run of whitespaces (/\s*/), while the new one will match a
> single whitespace, which is what we want here. Indeed, in other contexts,
I missed this nit in the last round. '/ /' will match a exactly one
space (not an arbitrary whitespace character), so this really should
be: s/single whitespace/single space/
> changing split(' ') to split(/ /) could potentially be a regression, however,
> here, when parsing the output of "rev-list --parents", whose output SHA-1's are
> each separated by a single space, splitting on a single space is perfectly
> correct.
>
> Signed-off-by: Célestin Matte <celestin.matte@xxxxxxxxxx>
> Signed-off-by: Matthieu Moy <matthieu.moy@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html