Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > Junio C Hamano wrote: >> I think this is the same as 5/6 and better explained in a single >> patch, as the rationale is the same: these commands can all take the >> usual revs and then paths, so using misnamed complete_FILE helper is >> wrong. >> >> Mind if I squashed them together? > > I'm okay with what you've queued in pu (sans some points raised by > SZEDER; looking into that), but you can squash them together if you > like. In any case, I think it is sensible not to remove the _file helper. We may want to fix it not to expand revname and do only the pathname, but that is a separate issue from using _revlist_file for the commands you updated completion for in these two patches. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html