Re: [RFC v2] reflog: show committer date in verbose mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jiang Xin <worldhello.net@xxxxxxxxx> writes:

> 2013/6/3 Ramkumar Ramachandra <artagnon@xxxxxxxxx>:
>> Jiang Xin wrote:
>>> It will be nice to add this pretty formatter automatically when run
>>> `git reflog` in verbose mode. And in order to support verbose mode, add
>>> new flag "verbose" in struct rev_info.
>>
>> Sorry I missed earlier revisions of this patch.  Generally speaking,
>> "verbose" is a bad way to control format-specifiers.  Why not add to
>> the list of pretty-format specifiers (like oneline, short, medium,
>> full)?  Also, this patch is extremely pervasive in that it teaches a
>> poorly defined "verbosity" to a very low layer: revision.c/revision.h.
>
> I also feel bad when adding new flag "verbose" into rev_info. = =b
>
> CommitDate is more significant than AuthorDate for reflog.

This is a curious statement, as I've seen it in a different context
recently.

Is it committer date that you really care about, or are you using it
as a substitute for something else you care more about, namely, the
time of the event the reflog entry was created (i.e. when you
committed, when you resetted, when you "branch -f"ed)?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]