2013/6/3 Ramkumar Ramachandra <artagnon@xxxxxxxxx>:
> Jiang Xin wrote:
>> It will be nice to add this pretty formatter automatically when run
>> `git reflog` in verbose mode. And in order to support verbose mode, add
>> new flag "verbose" in struct rev_info.
>
> Sorry I missed earlier revisions of this patch. Generally speaking,
> "verbose" is a bad way to control format-specifiers. Why not add to
> the list of pretty-format specifiers (like oneline, short, medium,
> full)? Also, this patch is extremely pervasive in that it teaches a
> poorly defined "verbosity" to a very low layer: revision.c/revision.h.
I also feel bad when adding new flag "verbose" into rev_info. = =b
CommitDate is more significant than AuthorDate for reflog. In order to
show CommitDate, at least we provide "fuller" formatter, such as
"git reflog --pretty=fuller". It's output is not as compact as:
$ git reflog show \
--pretty="%Cred%h%Creset %gd: %gs%n %Cblue%ci (%cr)%Creset%n %s"
Introduce new pretty-format like this is not suitable I think. Maybe
I have to define my own alias and use it myself. ;-)
--
Jiang Xin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html