On Fri, May 31, 2013 at 3:03 AM, Ramkumar Ramachandra <artagnon@xxxxxxxxx> wrote: > Felipe Contreras wrote: >> I was going to make these stylistic changes to make you happy, but >> then I realized the only that does really make sense is to change msg >> = nil to msg = false, and it's not even worth to waste a thought on >> changes like that. > > We don't have existing Ruby code in git.git to follow, so what I say > can obviously not have more weightage than "personal opinion". Don't > do things to "make me happy"; I am nobody. Have a good sense of style > and defend it instead of flaming me because you thought I was stalling > work. I already defended the style, only to hear the same comment again in the next iteration. >> So I'll move on to the next patches, hopefully Duy or Junio would have >> some comments of actual significance, or maybe you would too, but for >> the moment it seems pretty clear you are only stating opinions about >> what Ruby code-style you like best. > > I've done reviews of several iterations of this patch, and stylistic > comments were all that I had left: When a reviewer reaches that point, (s)he usually says: other than cosmetic preferences: Reviewed-by: me. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html