On Thu, May 30, 2013 at 6:31 AM, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > On Thu, May 30, 2013 at 4:01 AM, Ramkumar Ramachandra > Not a single one of these comments makes a difference at all, all of > them can wait until after the patch is merged, many of them are a > matter of preferences, and some of them have already been addressed as > precisely that: disagreements in style. I was going to make these stylistic changes to make you happy, but then I realized the only that does really make sense is to change msg = nil to msg = false, and it's not even worth to waste a thought on changes like that. So I'll move on to the next patches, hopefully Duy or Junio would have some comments of actual significance, or maybe you would too, but for the moment it seems pretty clear you are only stating opinions about what Ruby code-style you like best. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html