Torsten Bögershausen wrote: > One minor nit, or 2: > imap-send.c: In function ‘cram’: > imap-send.c:913: warning: statement with no effect > > This fixes it: > > diff --git a/imap-send.c b/imap-send.c > index 8ea180f..11577c9 100644 > --- a/imap-send.c > +++ b/imap-send.c > @@ -35,7 +35,7 @@ typedef void *SSL; > #define HMAC_Init(hmac, key, len, algo) CCHmacInit(hmac, algo, key, len) > #define HMAC_Update CCHmacUpdate > #define HMAC_Final(hmac, hash, ptr) CCHmacFinal(hmac, hash) > -#define HMAC_CTX_cleanup > +#define HMAC_CTX_cleanup(c) > #define EVP_md5() kCCHmacAlgMD5 > #else > #include <openssl/evp.h> Good catch. Thanks. > (And I think there are more minor nits: > #define HMAC_Final(hmac, hash, ptr) CCHmacFinal(hmac, hash) > could be written as > #define HMAC_Final(hmac, hash, ptr) CCHmacFinal((hmac), (hash)) > (Use paranthese around each parameter) > Similar change for HMAC_Init() Not needed --- the comma operator has lower precedence than any other, and any expression containing commas would have to already be surrounded by parentheses to be an argument to this function-like macro. Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html