On Sun, May 12, 2013 at 2:25 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > David Aguilar <davvid@xxxxxxxxx> writes: > >> Yup, warnings still remain, but only in imap-send.c. All the SHA1 >> ones are gone. Those were particularly bothersome since they affected >> several files. >> >> I haven't dug to deeply into how to fix these. In case anyone has any >> pointers, the warnings look like this: >> >> imap-send.c: In function ‘ssl_socket_perror’: >> imap-send.c:185: warning: ‘ERR_error_string’ is deprecated (declared >> at /usr/include/openssl/err.h:279) > > Hmph. > > I thought your separate imap-send patch switched to CommonCrypto. > Why are you still including from /usr/include/openssl/? > > By the way, is CommonCrypo anything "common"? I am geting an > impression that it is an Apple-only thing, and if that is the case > the naming feels somewhat funny. Far from common -- it's an Apple-ism. The imap-send patch switches the HMAC parts to CommonCrypto and do eliminate the HMAC warnings. It still includes the x509 headers from SSL. I haven't figured those out. -- David -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html