On Sun, May 12, 2013 at 11:37 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sat, May 11, 2013 at 4:22 AM, David Aguilar <davvid@xxxxxxxxx> wrote: >> Mac OS X Mountain Lion prints warnings when building git: >> >> warning: 'SHA1_Init' is deprecated >> (declared at /usr/include/openssl/sha.h:121) >> >> Silence the warnings by using the Common Digest SHA-1 >> functions for SHA1_Init(), SHA1_Update(), and SHA1_Final(). >> >> Add a COMMON_DIGEST_SHA1 knob to the Makefile to allow >> choosing this implementation and define it by default on Darwin. >> >> Signed-off-by: David Aguilar <davvid@xxxxxxxxx> >> --- >> Unchanged since last time; rebased to 3/3. > > Ignore my earlier response. I had not seen your revised patches. With > this patch series, the SHA1_Foo() warnings are indeed resolved, > however, there are still a bunch of remaining deprecation warnings > regarding ERR_error_string, SSL_get_error, X509_get_ext_d2i, and so > forth. Yup, warnings still remain, but only in imap-send.c. All the SHA1 ones are gone. Those were particularly bothersome since they affected several files. I haven't dug to deeply into how to fix these. In case anyone has any pointers, the warnings look like this: imap-send.c: In function ‘ssl_socket_perror’: imap-send.c:185: warning: ‘ERR_error_string’ is deprecated (declared at /usr/include/openssl/err.h:279) imap-send.c:185: warning: ‘ERR_get_error’ is deprecated (declared at /usr/include/openssl/err.h:266) imap-send.c: In function ‘socket_perror’: imap-send.c:193: warning: ‘SSL_get_error’ is deprecated (declared at /usr/include/openssl/ssl.h:1501) imap-send.c: In function ‘verify_hostname’: imap-send.c:245: warning: ‘X509_get_ext_d2i’ is deprecated (declared at /usr/include/openssl/x509.h:1151) imap-send.c:246: warning: ‘sk_num’ is deprecated (declared at /usr/include/openssl/stack.h:81) imap-send.c:248: warning: ‘sk_value’ is deprecated (declared at /usr/include/openssl/stack.h:82) imap-send.c:254: warning: ‘sk_pop_free’ is deprecated (declared at /usr/include/openssl/stack.h:89) imap-send.c:260: warning: ‘X509_get_subject_name’ is deprecated (declared at /usr/include/openssl/x509.h:1013) imap-send.c:262: warning: ‘X509_NAME_get_text_by_NID’ is deprecated (declared at /usr/include/openssl/x509.h:1099) imap-send.c: In function ‘ssl_socket_connect’: imap-send.c:281: warning: ‘SSL_library_init’ is deprecated (declared at /usr/include/openssl/ssl.h:1553) imap-send.c:282: warning: ‘SSL_load_error_strings’ is deprecated (declared at /usr/include/openssl/ssl.h:1416) imap-send.c:285: warning: ‘TLSv1_method’ is deprecated (declared at /usr/include/openssl/ssl.h:1519) imap-send.c:287: warning: ‘SSLv23_method’ is deprecated (declared at /usr/include/openssl/ssl.h:1515) imap-send.c:294: warning: ‘SSL_CTX_new’ is deprecated (declared at /usr/include/openssl/ssl.h:1346) imap-send.c:297: warning: ‘SSL_CTX_set_verify’ is deprecated (declared at /usr/include/openssl/ssl.h:1459) imap-send.c:299: warning: ‘SSL_CTX_set_default_verify_paths’ is deprecated (declared at /usr/include/openssl/ssl.h:1570) imap-send.c:303: warning: ‘SSL_new’ is deprecated (declared at /usr/include/openssl/ssl.h:1481) imap-send.c:308: warning: ‘SSL_set_rfd’ is deprecated (declared at /usr/include/openssl/ssl.h:1371) imap-send.c:312: warning: ‘SSL_set_wfd’ is deprecated (declared at /usr/include/openssl/ssl.h:1372) imap-send.c:323: warning: ‘SSL_ctrl’ is deprecated (declared at /usr/include/openssl/ssl.h:1496) imap-send.c:328: warning: ‘SSL_connect’ is deprecated (declared at /usr/include/openssl/ssl.h:1492) imap-send.c:336: warning: ‘SSL_get_peer_certificate’ is deprecated (declared at /usr/include/openssl/ssl.h:1450) imap-send.c: In function ‘socket_read’: imap-send.c:352: warning: ‘SSL_read’ is deprecated (declared at /usr/include/openssl/ssl.h:1493) imap-send.c: In function ‘socket_write’: imap-send.c:370: warning: ‘SSL_write’ is deprecated (declared at /usr/include/openssl/ssl.h:1495) imap-send.c: In function ‘socket_shutdown’: imap-send.c:387: warning: ‘SSL_shutdown’ is deprecated (declared at /usr/include/openssl/ssl.h:1532) imap-send.c:388: warning: ‘SSL_free’ is deprecated (declared at /usr/include/openssl/ssl.h:1490) imap-send.c: In function ‘cram’: imap-send.c:906: warning: ‘EVP_DecodeBlock’ is deprecated (declared at /usr/include/openssl/evp.h:634) imap-send.c:913: warning: statement with no effect imap-send.c:927: warning: ‘EVP_EncodeBlock’ is deprecated (declared at /usr/include/openssl/evp.h:627) Cheers, -- David -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html