On Wed, May 8, 2013 at 12:55 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> In some circumstances 'git log' might fail, but not because the @ >> parsing failed. For example: 'git rev-parse' might succeed and return a >> bad object, and then 'git log' would fail. >> >> The layer we want to test is revision parsing, so let's test that >> directly. > > Hmph, but > > git rev-parse Makefile > > would happily succeed if there happens to be Makefile in the > directory. > > Are we expecting that they are always object names? If that is the > case, perhaps > > git rev-parse --verify "$1" > > would express the intention better. Probably, although the same would fail before this patch. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html