Hi, While trying to add support for the @ shortcut lots of cleanups arised. Here they are in a single series. Felipe Contreras (7): tests: at-combinations: simplify setup tests: at-combinations: check ref names directly tests: at-combinations: improve nonsense() sha1_name: remove no-op sha1_name: remove unnecessary braces sha1_name: avoid Yoda conditions sha1_name: reorganize get_sha1_basic() Ramkumar Ramachandra (4): tests: at-combinations: increase coverage tests: at-combinations: @{N} versus HEAD@{N} sha1_name: don't waste cycles in the @-parsing loop sha1_name: check @{-N} errors sooner sha1_name.c | 42 +++++++++++++++++++--------------- t/t1508-at-combinations.sh | 56 +++++++++++++++++++++++++++++++++------------- 2 files changed, 64 insertions(+), 34 deletions(-) -- 1.8.3.rc0.401.g45bba44 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html