Junio C Hamano wrote:
> I do not think anybody considered the approach to look at the commit
> object name and making sure it appears in the reflog that implements
> the stash. It sounds like a more robust check if done right.
Actually, if you think about it, there is really only one way to
specify revisions in the stash's reflog: stash@*. Since these
commits don't have to be reachable from any refs in the general case,
all the other revision syntaxes are useless. So, I would argue that
"${REV%@*}" is sufficient and correct*: anything beyond it is an
unnecessary overhead.
However, the initial bug is still valid: show should not show
something that pop cannot operate on.
* although I'd have been more comfortable if we had a neater way to specify that
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html