On 02.04.13 01:40, Jeff King wrote: > On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote: > >> On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras >> <felipe.contreras@xxxxxxxxx> wrote: >>> +export TEST_LINT := >> >> I think "test-lint-executable" still makes sense here. > > Also test-lint-shell-syntax, which finds a problem with the current > code: > > $ cd contrib/remote-helpers > $ make test TEST_LINT=test-lint-shell-syntax > make -e -C ../../t test > make[1]: Entering directory `/home/peff/compile/git/t' > rm -f -r test-results > /home/peff/compile/git/contrib/remote-helpers/test-bzr.sh:139: error: echo -n is not portable (please use printf): echo -n content > expected && > make[1]: *** [test-lint-shell-syntax] Error 1 > make[1]: Leaving directory `/home/peff/compile/git/t' > make: *** [test] Error 2 > > I think the check for duplicate-numbers is the only one that does not > make sense. [] Not sure about that, I send a suggestion of a patch in a minute. Highlights: 1) - rename the contrib test cases and assigns real TC numbers 2) - Forward the numbers into the main "test Makefile" 1) Will probably collide with Felipe's changes, so we just can pick up the idea. 2) Is for only review. If we agree on the re-numbering of TC's in contrib, we can apply a second round of the patch later. /Torsten -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html