On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote: > On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras > <felipe.contreras@xxxxxxxxx> wrote: > > +export TEST_LINT := > > I think "test-lint-executable" still makes sense here. Also test-lint-shell-syntax, which finds a problem with the current code: $ cd contrib/remote-helpers $ make test TEST_LINT=test-lint-shell-syntax make -e -C ../../t test make[1]: Entering directory `/home/peff/compile/git/t' rm -f -r test-results /home/peff/compile/git/contrib/remote-helpers/test-bzr.sh:139: error: echo -n is not portable (please use printf): echo -n content > expected && make[1]: *** [test-lint-shell-syntax] Error 1 make[1]: Leaving directory `/home/peff/compile/git/t' make: *** [test] Error 2 I think the check for duplicate-numbers is the only one that does not make sense. Unfortunately it is not as simple as using $(filter-out) to get rid of it from TEST_LINT, as that variable may not even be set until we chain to the other Makefile (e.g., if it comes from loading config.mak). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html