Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > Junio C Hamano wrote: >> Jeff King <peff@xxxxxxxx> writes: >>> [...] >> Thanks. That is one of the reasons why we do not want to see too >> many custom test helper functions. > > I noticed that you queued my original series without modification in > rr/triangle. Should I submit a re-roll with Peff's suggestion > incorporated? If you want the topic to make progress, yes. The only reason a topic is queued in 'pu' is to let me not pay attention to it, without risking to forget about it completely ;-). The topics on 'pu' have potential to be a useful change even though they are far from ready for 'next'. By queuing on 'pu', rather than just letting them sit in the mail archive and relying on the author to send follow-ups, I can send out "what happened to this topic?" inquiries from time to time, without paying constant attention to them. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html