Thomas Rast <trast@xxxxxxxxxxxxxxx> writes: > It apparently relates to the use of .idx.offset to compute the "next" > offset, cf. append_obj_to_pack(): > > struct object_entry *obj = &objects[nr_objects++]; > ... > obj[1].idx.offset = obj[0].idx.offset + n; > obj[1].idx.offset += write_compressed(f, buf, size); > > So you trashed the offset of the first object after all the objects that > are actually *in* the patch. > > And with that: ACK. Ahh, I also was scratching my head about that +1 thing. After all, the +1 in the argument to xrealloc() was already a clue. Thanks both for digging to the bottom of this one. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html