On Tue, Mar 19, 2013 at 04:33:42PM +0100, Thomas Rast wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
> > Commit 38a4556 (index-pack: start learning to emulate
> > "verify-pack -v", 2011-06-03) added a "delta_depth" counter
> > to each "struct object_entry". Initially, all object entries
> > have their depth set to 0; in resolve_delta, we then set the
> > depth of each delta to "base + 1". Base entries never have
> > their depth touched, and remain at 0.
>
> This patch causes index-pack to fail on the pack that triggered the
> whole discussion. More in a minute in another side thread, but
> meanwhile: NAK until we understand what is really going on here.
Odd; that's what I was testing with, and it worked fine.
Let me double-check that I didn't screw up my tests. I initially did
something more like:
if (is_delta_type(base->obj->type))
delta_obj->delta_depth = base->obj->delta_depth + 1;
else
delta_obj->delta_depth = 1;
and I'm wondering if I screwed up testing the revised version.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html