Jeff King <peff@xxxxxxxx> writes:
> static int maildir_filename_cmp(const char *a, const char *b)
> {
> - while (1) {
> + while (*a && *b) {
> if (isdigit(*a) && isdigit(*b)) {
> long int na, nb;
> na = strtol(a, (char **)&a, 10);
> @@ -148,6 +148,7 @@ static int maildir_filename_cmp(const char *a, const char *b)
> b++;
> }
> }
> + return *a - *b;
You should always cast to unsigned char when determining the order of
characters, to be consistent with strcmp/memcmp.
Andreas.
--
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html