On Wed, Feb 06, 2013 at 07:56:08AM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Is it worth having a strbuf_set* family of functions to match the > > strbuf_add*? We seem to have these sorts of errors with strbuf from time > > to time, and I wonder if that would make it easier (and more readable) > > to do the right thing. > > Possibly. > > The callsite below may be a poor example, though; you would need the > _reset() even if you change the _addstr() we can see in the context > to _setstr() to make sure later strbuf_*(type) will start from a > clean slate when !t anyway, no? Ah, true. Let's not worry about it, then. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html