On Tue, Jan 09, 2007 at 10:02:06AM +0000, Catalin Marinas wrote: > There is 'stg series --graphical' that invokes gitk. For some reason I did not look for this functionality in that place :) But it is a bit different, in that unapplied patches appear detached from the whole history. Possibly out of personal taste, I do not find this very useful, and prefer to see them as "gitk --all" shows them. > Maybe the 'show' command could have a similar option. Hm, not sure. "show" is about a patch, not a stack. (let's go off-topic) That makes me think that such command names like "show" are a bit too general: stgit uses "show" for patches, but nothing says it is for a patch and not a series. Also, when presenting GIT/StGIT to co-workers, I found them to be confused by eg. "stg push" and "stg commit" having different semantics than "git push" and "git commit". Finally, we have some "stgit commands" (eg. branch), which are not only real commands, but also give access to sub-commands. Maybe some restucturing of commands is called for. One possibility would be to go with prefixes (eg. ppush, pshow), but that does not address the sub-commands issue, which would have to be dealt with another way, possibly by multiplying commands (branch -> blist, bcreate, etc), which I'm not very fond of. Another would be to generalize command groups, and acknowledge subcommands as such. Eg: stg branch --create -> stg branch create stg show -> stg patch show stg push -> stg patch push The latter obviously suggests that some would want to keep "stg push" as an alias (here comes again the idea of programable aliases like we already have for GIT. > I'm a bit reluctant to these patches. I really don't like mixing > different languages (python and shell script) in the StGIT command > implementations. I concur. This is why I submitted them as contrib/ stuff. > Some of the patches you posted can be implemented in Python as either > new commands or extensions to the current ones (I'll follow up to your > other e-mails). Right - indeed they can be seen as prototypes for future clean features. I'm simply not used enough to python, and it was quicker for me to get those prototypes in shape this way. Best regards, -- Yann. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html