Michael Haggerty wrote: > Signed-off-by: Michael Haggerty <mhagger@xxxxxxxxxxxx> > --- > imap-send.c | 31 ++++++++----------------------- > 1 file changed, 8 insertions(+), 23 deletions(-) I like the code reduction, but my nighttime brain doesn't have the patience to understand the preimage or postimage, and the above description doesn't give any hints. Maybe a comment right above the function definition describing its contract would help to prepare the daunted reader (and to let the uninterested understand call sites without reading the implementation). Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html